WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] fix misc issues related to allowing support of m

To: Jan Beulich <jbeulich@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] fix misc issues related to allowing support of more CPUs
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Sat, 20 Sep 2008 09:36:25 +0100
Cc:
Delivery-date: Sat, 20 Sep 2008 01:36:17 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <48D3BEE7.76E4.0078.0@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acka+/eaNgkGnIbvEd2iEwAWy6hiGQ==
Thread-topic: [Xen-devel] [PATCH] fix misc issues related to allowing support of more CPUs
User-agent: Microsoft-Entourage/11.4.0.080122
On 19/9/08 14:01, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:

> Includes a small improvement (I think) to last_cpu(), and a necessary
> conversion from BUG_ON() to WARN_ON() in vsnprintf().

Why must it be WARN_ON()? You think you could specify strings so long that
they overflow 32 bits? You've got other problems in that case.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel