Hi,
Yoshiaki Tamura wrote:
> Hi.
>
> When I compiled xen-3.3-testing with DEBUG_TRACE_DUMP in xen/include/xen/lib.h
> turned on, I got some errors at SHADOW_PRINTK.
> The following patch will fix the arguments passed to SHADOW_PRINTK in
> xen/arch/x86/mm/shadow/common.c and xen/arch/x86/mm/shadow/multi.c.
My fault, the va argument was removed with recent changes in the OOS
code and it is unneeded now.
> SHADOW_PRINTK("d=%d, v=%d, gmfn=%05lx, va=%lx\n",
> - v->domain->domain_id, v->vcpu_id, mfn_x(gmfn), va);
> + v->domain->domain_id, v->vcpu_id, mfn_x(gmfn),
> + sh_map_domain_page(gmfn));
>
> /* Need to pull write access so the page *stays* in sync. */
> if ( oos_remove_write_access(v, gmfn, fixup) )
> @@ -953,7 +954,8 @@ int sh_unsync(struct vcpu *v, mfn_t gmfn
> ASSERT(shadow_locked_by_me(v->domain));
>
> SHADOW_PRINTK("d=%d, v=%d, gmfn=%05lx va %lx\n",
> - v->domain->domain_id, v->vcpu_id, mfn_x(gmfn), va);
> + v->domain->domain_id, v->vcpu_id, mfn_x(gmfn),
> + sh_map_domain_page(gmfn));
These will likely break Xen in 32 bit, since you should unmap the gmfn
in those architecture. As I said, the va argument is unneeded now, so
you should remove it.
Thanks,
Gianluca
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
Home