|
|
|
|
|
|
|
|
|
|
xen-devel
[Xen-devel] Re: [Qemu-devel] [PATCH 1/2] xenner: add event channel imple
Anthony Liguori wrote:
> Gerd Hoffmann wrote:
>> The patch also adds a XenEvtOps struct with function pointers for the
>> xc_evtchn_* family, which is used to switch between libxenctrl and the
>> qemu implementation at runtime. By default libxenctrl is used.
>
> I suppose the QEMU implementation is to eventually eliminate the need
> for libxc?
Yes, for xen emulation (aka xenner).
When running on Xen libxc is still needed of course.
> Do you also plan on doing a XenStore implementation within QEMU?
Yes.
>> @@ -521,6 +521,7 @@ endif
>> # xen backend driver support
>> XEN_OBJS := xen_machine_pv.o xen_backend.o xen_devconfig.o
>> xen_domainbuild.o
>> XEN_OBJS += xen_console.o xen_framebuffer.o xen_disk.o xen_nic.o
>> +XEN_OBJS += xenner_libxc_evtchn.o
>
> Historically, we didn't have directories in QEMU because we used CVS and
> directories are a nightmare. With the shear number of files being added
> for Xen, it probably makes sense to stick them all in a directory.
Hmm, the xen guys vetoed file renames, so I don't feel like sticking
stuff used by xen somewhere else. For the emulation bits aka
xenner*.[ch] it should be no problem though. New xenner/ toplevel
directory?
> Minor nit, make sure to have copyrights in all of your files.
> [ ... more review comments ... ]
Thanks, I'll fix it up.
cheers,
Gerd
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
|
|