 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] hvmemul_virtual_to_linear() doesn't care about direction
| To: | "Byrne, John (HP Labs)" <john.l.byrne@xxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] hvmemul_virtual_to_linear() doesn't care about direction-flag? |
| From: | Keir Fraser <keir.fraser@xxxxxxxxxxxxx> |
| Date: | Tue, 19 Aug 2008 19:41:34 +0100 |
| Cc: | |
| Delivery-date: | Tue, 19 Aug 2008 11:41:59 -0700 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <469F2699A483D44BA6D2B311B1089D3A4338FC6113@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| Thread-index: | AckBYgqYPA8ffyuBQxqCY+AgRFffRQAclVJ+AAUtT5kACPVKTQADeijQAAKjNooAAE65MAABJmdf |
| Thread-topic: | [Xen-devel] hvmemul_virtual_to_linear() doesn't care about direction-flag? |
| User-agent: | Microsoft-Entourage/11.4.0.080122 |
On 19/8/08 19:33, "Byrne, John (HP Labs)" <john.l.byrne@xxxxxx> wrote:
> Wrong assert. I confused you, my fault. The ASSERT(!reverse) I figured out.
>
> The ASSERT I was concerned about is this:
>
> if ( (hvmemul_ctxt->ctxt.regs->eflags & X86_EFLAGS_DF) && (*reps > 1) )
> {
> ASSERT(offset >= ((*reps - 1) * bytes_per_rep));
>
> However, I just read truncate_ea_and_reps() in the emulator which should
> guarantee this.
Yes, I considered giving that one a comment too. Now I will do so.
-- Keir
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
| Previous by Date: | RE: [Xen-devel] hvmemul_virtual_to_linear() doesn't care about direction-flag?, Byrne, John (HP Labs) |
|---|---|
| Next by Date: | [Xen-devel] [PATCH] xen: clean up domain mode predicates, Jeremy Fitzhardinge |
| Previous by Thread: | RE: [Xen-devel] hvmemul_virtual_to_linear() doesn't care about direction-flag?, Byrne, John (HP Labs) |
| Next by Thread: | Re: [Xen-devel] hvmemul_virtual_to_linear() doesn't care about direction-flag?, Trolle Selander |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
