WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] stubdom: fix read-only disks access

To: Samuel Thibault <samuel.thibault@xxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] stubdom: fix read-only disks access
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Sun, 03 Aug 2008 18:13:26 +0100
Cc:
Delivery-date: Sun, 03 Aug 2008 10:13:47 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20080801181750.GF4553@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acj1jD27fEdgxWF/Ed21FgAWy6hiGQ==
Thread-topic: [Xen-devel] [PATCH] stubdom: fix read-only disks access
User-agent: Microsoft-Entourage/11.4.0.080122
Is no patch required for ioemu-remote?

 -- Keir

On 1/8/08 19:17, "Samuel Thibault" <samuel.thibault@xxxxxxxxxxxxx> wrote:

> 
> stubdom: fix read-only disks access
> 
> There is no need for a flush on read-only disks.  It would actually even
> error out and disturb the guest.
> 
> Signed-off-by: Samuel Thibault <samuel.thibault@xxxxxxxxxxxxx>
> 
> diff -r 3dedb6209991 tools/ioemu/block-vbd.c
> --- a/tools/ioemu/block-vbd.c Fri Aug 01 12:18:02 2008 +0100
> +++ b/tools/ioemu/block-vbd.c Fri Aug 01 19:16:52 2008 +0100
> @@ -273,6 +273,10 @@ static BlockDriverAIOCB *vbd_aio_flush(B
>      BDRVVbdState *s = bs->opaque;
>      VbdAIOCB *acb = NULL;
>  
> +    if (s->info.mode == O_RDONLY) {
> +        cb(opaque, 0);
> +        return NULL;
> +    }
>      if (s->info.barrier == 1) {
>          acb = vbd_aio_setup(bs, 0, NULL, 0,
>                  s->info.flush == 1 ? vbd_nop_cb : cb, opaque);
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>