Re: [Xen-devel] Re: [PATCH] ioemu-remote: ACPI S3 state wake up

[Keir Fraser <keir.fraser@xxxxxxxxxxxxx>]

I think Jean's original and only problem was with the s3_resume_flag.

 -- Keir

On 24/7/08 13:54, "Trolle Selander" <trolle.selander@xxxxxxxxx> wrote:

> Was this s3_resume_flag the _only_ thing that needed to be in r/w space, or was that just the only thing in the rombios range? That is - should we revert to the original code, or to the revised version i sent earlier today that protected the actual ROMs but left a r/w gap covering the unused areas and the SMBIOS- & ACPI- tables? 
>
> -- Trolle
>
> On Thu, Jul 24, 2008 at 1:45 PM, Keir Fraser <keir.fraser@xxxxxxxxxxxxx> wrote:
> > On 24/7/08 13:12, "Jean Guyader" <jean.guyader@xxxxxxxxxxxxx> wrote:
> >
> > > Jean Guyader wrote:
> > >> I already tried to reduce the rw area, and just keep 0xe0 -> 0xef. But
> > >> obviously it doesn't work the device model needs to write on this frame
> > >> 0xf1. I still don't figure out why.
> > >
> > > The rombios write on this page because of this flags s3_resume_flag
> > > (rombios.c:98883). I don't know if it's a good reason to set the
> > > rombios as rw. However it's bad to set the first 2 pages of the rombios
> > > as rw just because of that.
> > > Any suggestions ?
> >
> > In that case the changes to ioemu-remote should be reverted. The correct fix
> > is to move the S3 resume flag into the EBDA. I have committed this fix as
> > xen-unstable.hg:18120.
> >
> >  -- Keir




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel