WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Re: [PATCH] ioemu-remote: ACPI S3 state wake up

To: Trolle Selander <trolle.selander@xxxxxxxxx>
Subject: Re: [Xen-devel] Re: [PATCH] ioemu-remote: ACPI S3 state wake up
From: Jean Guyader <jean.guyader@xxxxxxxxxxxxx>
Date: Thu, 24 Jul 2008 11:48:40 +0100
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Delivery-date: Thu, 24 Jul 2008 03:49:03 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <515922b50807240323k99474dfnb679c40290a8aa11@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <48876F9E.8020305@xxxxxxxxxxxxx> <18567.29232.933108.405959@xxxxxxxxxxxxxxxxxxxxxxxx> <515922b50807240323k99474dfnb679c40290a8aa11@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla-Thunderbird 2.0.0.14 (X11/20080509)
I already tried to reduce the rw area, and just keep 0xe0 -> 0xef. But obviously it doesn't work the device model needs to write on this frame 0xf1. I still don't figure out why.


Trolle Selander wrote:
Don't leave the main rombios unprotected. I also added a comment to explain the "magic numbers", since their meaning is perhaps not as obvious as I thought, in particular now that we're no longer blanket-protecting the entire firmware area anymore.

/ Trolle

Signed-off-by: Trolle Selander <trolle.selander@xxxxxxxxxxxxx <mailto:trolle.selander@xxxxxxxxxxxxx> <mailto:trolle.selander@xxxxxxxxxxxxx>

On Wed, Jul 23, 2008 at 7:02 PM, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx <mailto:Ian.Jackson@xxxxxxxxxxxxx>> wrote:

    Jean Guyader writes ("[PATCH] ioemu-remote: ACPI S3 state wake up"):
     > ioemu-remote: The device model needs to write in the ACPI tables
    when it
     > wakes up from S3 state.

    I've applied this but I have to say these magic numbers
     > -        if (xc_hvm_set_mem_type(xc_handle, domid, mem_type,
    0xc0, 0x40))
     > +        if (xc_hvm_set_mem_type(xc_handle, domid, mem_type,
    0xc0, 0x20))
    are pretty unpleasant!  Are they directly derived from addresses
    specified in ACPI ?  I haven't looked ...

    Ian.

    _______________________________________________
    Xen-devel mailing list
    Xen-devel@xxxxxxxxxxxxxxxxxxx <mailto:Xen-devel@xxxxxxxxxxxxxxxxxxx>
    http://lists.xensource.com/xen-devel




--
Jean Guyader

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel