WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] ioemu: alternative patch fixing pt_chk_bar_overl

Yuji Shimada writes ("Re: [Xen-devel] [PATCH] ioemu: alternative patch fixing 
pt_chk_bar_overlap"):
> I've created new patch for ioemu-remote. If you apply it to ioemu-remote,
> the implementation of passthrough device will become almost the same for
> both ioemu trees.

Thanks for that.

> The patch contains following patches which have been applied to Xen
> Unstable Changeset 17959-18076.

This patch introduces a couple of new warnings:

 /u/iwj/work/qemu-iwj.git/hw/pass-through.c: In function 'pt_iomem_map':
 /u/iwj/work/qemu-iwj.git/hw/pass-through.c:821: warning: format '%lx' expects 
type 'long unsigned int', but argument 5 has type 'uint64_t'

and

 In file included from /u/iwj/work/qemu-iwj.git/hw/pt-msi.h:5,
                  from /u/iwj/work/qemu-iwj.git/hw/pt-msi.c:22:
 /u/iwj/work/qemu-iwj.git/hw/pass-through.h:57:1: warning: 
"PCI_MSI_FLAGS_MASK_BIT" redefined
 In file included from /u/iwj/work/qemu-iwj.git/hw/pass-through.h:23,
                  from /u/iwj/work/qemu-iwj.git/hw/pt-msi.h:5,
                  from /u/iwj/work/qemu-iwj.git/hw/pt-msi.c:22:
 /usr/include/pci/header.h:274:1: warning: this is the location of the previous 
definition

The former was easy to fix.  The latter is not critical so I have
committed your patch anyway, but it would be nice to get rid of it.

Who do you think owns this part of the namespace ?  Should we sprinkle
some #ifdefs in pass-through.h ?  On my system (Debian etch)
/usr/include/pci/header.h is part of pciutils-dev 1:2.2.4~pre4-1.  The
definition is identical in effect.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel