WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] [Patch] ioemu-remote: fix gcc4 build problem (?)

To: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Subject: [Xen-devel] [Patch] ioemu-remote: fix gcc4 build problem (?)
From: Andre Przywara <andre.przywara@xxxxxxx>
Date: Sun, 20 Jul 2008 15:29:07 +0200
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Sun, 20 Jul 2008 06:29:45 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird 2.0.0.14 (X11/20080421)
Ian,

although I read that the gcc4 build problem should already be fixed, I cannot ack this for me: I just did $ git clone http://xenbits.xensource.com/git-http/qemu-xen-unstable.git and "$ hg pull -u" in xen-staging and still configure stops with missing gcc3. In ioemu-remote "git log" says the latest patch was:
----------
commit 1ec7aa3263bc7fd78bcc40e4ceb2ca067a1a8687
Author: Ian Jackson <iwj@xxxxxxxxxxxxxxxxxxxxxxxx>
Date:   Mon Jul 14 13:46:28 2008 +0100
    qemu ioemu rendering fixes for palette handling (another dropped patch)
.....
----------

If a fix is already submitted, it would be nice if someone could point me how keep my tree up-to-date.

Anyway now my version of the patch:
AFAIK the qemu gcc3 build restriction does not apply to ioemu, in the old embedded tree "check_gcc" was set to "no" per default in tools/ioemu/configure. Either we do the same in the ioemu-remote tree or use the below patch to fix the shell test error (already in qemu since May 23rd: http://lists.gnu.org/archive/html/qemu-devel/2008-05/msg00875.html) and call configure with --disable-gcc-check (which is closer to the upstream qemu tree).

Signed-off-by: Andre Przywara <andre.przywara@xxxxxxx>
Original QEMU patch by Paul Brook

Regards,
Andre.

--
Andre Przywara
AMD-Operating System Research Center (OSRC), Dresden, Germany
Tel: +49 351 277-84917
----to satisfy European Law for business letters:
AMD Saxony Limited Liability Company & Co. KG,
Wilschdorfer Landstr. 101, 01109 Dresden, Germany
Register Court Dresden: HRA 4896, General Partner authorized
to represent: AMD Saxony LLC (Wilmington, Delaware, US)
General Manager of AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy
diff --git a/configure b/configure
index 2366aa6..30bab12 100755
--- a/configure
+++ b/configure
@@ -1241,7 +1241,7 @@ case "$target_cpu" in
     fi
     echo "#define CONFIG_DYNGEN_OP 1" >> $config_h
     gcc3minver=`$cc --version 2> /dev/null| fgrep "(GCC) 3." | awk '{ print $3 
}' | cut -f2 -d.`
-    if test -n "$gcc3minver" -a $gcc3minver -gt 3
+    if test -n "$gcc3minver" && test $gcc3minver -gt 3
     then
       echo "HAVE_GT_GCC_3_3=true" >> $config_mak
     else
diff --git a/xen-setup b/xen-setup
index 755b9ec..b0eda89 100755
--- a/xen-setup
+++ b/xen-setup
@@ -9,7 +9,7 @@ rm -f config-host.mak
 
 if test -f config-host.h; then mv config-host.h config-host.h~; fi
 
-./configure --disable-curses --disable-slirp "$@" --prefix=/usr
+./configure --disable-gcc-check --disable-curses --disable-slirp "$@" 
--prefix=/usr
 
 target=i386-dm
 
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel