WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH] xend: PV machines have no ioemu network

To: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Subject: [Xen-devel] Re: [PATCH] xend: PV machines have no ioemu network
From: Kevin Wolf <kwolf@xxxxxxx>
Date: Tue, 15 Jul 2008 18:44:46 +0200
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>, Keir Fraser <keir.fraser@xxxxxxxxxxxxx>, Jean Guyader <jean.guyader@xxxxxxxxxxxxx>
Delivery-date: Tue, 15 Jul 2008 09:47:11 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <487CBBBE.4050405@xxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <C4A0BAEA.1AF3A%keir.fraser@xxxxxxxxxxxxx> <487BC7E0.9040106@xxxxxxxx> <487C66CF.1030104@xxxxxxx> <487CBBBE.4050405@xxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird 2.0.0.12 (X11/20071114)
Jeremy Fitzhardinge schrieb:
> Kevin Wolf wrote:
>> Ians wants to keep changes from upstream qemu as small as possible in
>> those files shared with qemu. I think this is the main reason why he
>> didn't do it, and as long as slirp was compiled it just worked.
>>
>> Additionally, specifying no -net parameter always meant -net nic -net
>> user for qemu, so we would not only change common code, but also the
>> semantics of the command line parameters. I think this is even worse.
>>   
> 
> If you've disabled slirp then "-net user" doesn't work; it would be
> pretty silly for qemu to default to using "-net user" if it can't
> possibly work.  I think my patch is a bugfix for base qemu.

Agreed. If you submit it to upstream qemu, it's a proper fix.

Kevin

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel