[Xen-devel] qemu-dm without slirp

[Jeremy Fitzhardinge <jeremy@xxxxxxxx>]

Keir Fraser wrote:
> On 13/7/08 07:27, "Jeremy Fitzhardinge" <jeremy@xxxxxxxx> wrote:
>
>   
> > Jeremy Fitzhardinge wrote:
> >     
> > > but other stuff is failing... tapdisk?
> > >       
> > No, pvfb.  Hm.
> >     
> pvfb is built into qemu now?
>   
Ah.  I compiled qemu with --disable-gcc-check --disable-slirp as had 
been discussed on the list.  But that causes qemu-dm to fail with 
"Unknown network device: user", because it always  uses "user" (slirp) 
if you don't define any other net conifg.
I did this:

--- a/vl.c
+++ b/vl.c
@@ -8598,9 +8598,10 @@ int main(int argc, char **argv)
    /* init network clients */
    if (nb_net_clients == 0) {
        /* if no clients, we use a default config */
-        net_clients[0] = "nic";
-        net_clients[1] = "user";
-        nb_net_clients = 2;
+        net_clients[nb_net_clients++] = "nic";
+#ifdef CONFIG_SLIRP
+        net_clients[nb_net_clients++] = "user";
+#endif
    }

    for(i = 0;i < nb_net_clients; i++) {

to fix it.  The old qemu code put that whole default net configuration 
in #ifndef CONFIG_DM.  Ian, did you deliberately not do that in the new 
code, or is it an oversight?
   J

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel