| |
|
 |
|
 |
|
|
|
| |
|
|
xen-devel
Re: [Xen-devel] [PATCH] xend: open qemu-dm log files in append mode
Ian Jackson wrote:
Yosuke Iwamatsu writes ("Re: [Xen-devel] [PATCH] xend: open qemu-dm log files in
append mode"):
Done in qemu-log-rotate-config.patch.
I've set the logrotate count default to 10. It is small enough not to
annoy users by filling xen log directory with many files, I think.
I also created a patch (qemu-log-append-config.patch) which opens
qemu-dm logfiles in append mode if the logrotate count is 0. If this
makes sense, please apply it after qemu-log-rotate-config.patch.
That's great. And, after a quick review, your patch looks sane to me.
I assume you've tested both cases.
Year, tested and it looked working well.
You forgot to add a Signed-Off-By.
Signed-off-bys are written inside the attachments themselves, but anyway
here is confirmation:
Signed-off-by: Yosuke Iwamatsu <y-iwamatsu@xxxxxxxxxxxxx>
--Yosuke
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
| |
|
Home