WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] xend: open qemu-dm log files in append mode

To: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] xend: open qemu-dm log files in append mode
From: Yosuke Iwamatsu <y-iwamatsu@xxxxxxxxxxxxx>
Date: Fri, 27 Jun 2008 18:31:08 +0900
Cc: Yuji Shimada <shimada-yxb@xxxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx, berrange@xxxxxxxxxx
Delivery-date: Fri, 27 Jun 2008 02:32:22 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <18531.45028.236043.309416@xxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <486323E3.3000407@xxxxxxxxxxxxx> <18531.44047.726185.484243@xxxxxxxxxxxxxxxxxxxxxxxx> <20080626145100.GO20952@xxxxxxxxxx> <18531.45028.236043.309416@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird 2.0.0.14 (Windows/20080421)
Ian Jackson wrote:
Daniel P. Berrange writes ("Re: [Xen-devel] [PATCH] xend: open qemu-dm log files in 
append mode"):
XenD already does rotate the qemu logs unless the code I added todo that has since been removed, so if the domain reboots we should keep
at least one historic log

It only keeps one.  I think Yuji Shimada would like more than one but
that would be a straightforward change to make to the code.

Ian.

So the attached patch improves the qemu-log rotation in xend to keep
maximum of 20 backup logfiles per domain. I still prefer the previous
patch that will avoid information loss when, for example, a guest
repeats cursh and reboot. But this patch might be at least a little bit
better than the current one-historic-backup solution. Any comment?

Thanks,
  Yosuke

Attachment: qemu-log-rotate.patch
Description: all/allfiles

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel