Sorry, forget the attachment. :)
> -----Original Message-----
> From: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
> [mailto:xen-devel-bounces@xxxxxxxxxxxxxxxxxxx] On Behalf Of Zhang, Li
> Sent: Wednesday, June 25, 2008 10:36 PM
> To: Keir Fraser; xen-devel@xxxxxxxxxxxxxxxxxxx
> Subject: [Xen-devel] RE: [patch][vtd] Remove ASSERT in hvmloader.c
> whenassigning disk controller to a guest
>
> Hi, Keir
> If the device is not PIIX3 IDE, we also should do the two
pci_writew().
> The 0x40 and 0x42 are timing registers of IDE0 and IDE1, and they are
> used to enable the IDE command decoding function.
> And from the PIIX3, ICH to ICH10, the IDE timing registers addresses
are
> the same. So I think removing the ASSERT is OK. The original comment
in
> the file is a little puzzling.
> The attachment is a new version.
>
> > -----Original Message-----
> > From: Keir Fraser [mailto:keir.fraser@xxxxxxxxxxxxx]
> > Sent: Wednesday, June 25, 2008 7:31 PM
> > To: Zhang, Li; xen-devel@xxxxxxxxxxxxxxxxxxx
> > Subject: Re: [patch][vtd] Remove ASSERT in hvmloader.c when
assigning
> disk
> > controller to a guest
> >
> > If the device is not PIIX3 IDE then presumably we should not do
the
> two
> > pci_writew() invocations either? Words 0x40 and 0x42 in the PCI
> config space
> > could have a completely different purpose in a different IDE
> controller.
> >
> > -- Keir
> >
> > On 25/6/08 12:21, "Zhang, Li" <li.zhang@xxxxxxxxx> wrote:
> >
> > > Hi,
> > > If boot a HVM guest configured with a physical disk, it will
check
> the
> > > device id of emulated device and then check physical device. But
> the
> > > device id of physical device is not necessary 0x7010. So ASSERT
may
> > > fail, and the guest crashes at this point. This patch removes
the
> ASSERT
> > > of vendor_id and device_id, to assign SATA controller to guest.
> > >
> > > Signed-off-by: Li Zhang <li.zhang@xxxxxxxxx>
> > >
> > > Thanks
> > > -Li
> > >
> >
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel
hvmloader.patch
Description: hvmloader.patch
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
Home