[Xen-devel] Re: [patch][vtd] Remove ASSERT in hvmloader.c when a

To:	"Zhang, Li" <li.zhang@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject:	[Xen-devel] Re: [patch][vtd] Remove ASSERT in hvmloader.c when assigning disk controller to a guest
From:	Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date:	Wed, 25 Jun 2008 12:31:21 +0100
Delivery-date:	Wed, 25 Jun 2008 04:32:02 -0700
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxx
In-reply-to:	<14B8575781A1414FA0D4F6649C4D719001827DAA@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index:	AcjWta1A49gT7Ps4RHaMe8nse4Bn7gAAVCFq
Thread-topic:	[patch][vtd] Remove ASSERT in hvmloader.c when assigning disk controller to a guest
User-agent:	Microsoft-Entourage/11.4.0.080122

If the device is not PIIX3 IDE then presumably we should not do the two
pci_writew() invocations either? Words 0x40 and 0x42 in the PCI config space
could have a completely different purpose in a different IDE controller.

 -- Keir

On 25/6/08 12:21, "Zhang, Li" <li.zhang@xxxxxxxxx> wrote:

> Hi, 
> If boot a HVM guest configured with a physical disk, it will check the
> device id of emulated device and then check physical device. But the
> device id of physical device is not necessary 0x7010. So ASSERT may
> fail, and the guest crashes at this point. This patch removes the ASSERT
> of vendor_id and device_id, to assign SATA controller to guest.
> 
> Signed-off-by: Li Zhang <li.zhang@xxxxxxxxx>
> 
> Thanks
> -Li
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread]

Current Thread

[Next in Thread>

Previous by Date:

[Xen-devel] [patch][vtd] Remove ASSERT in hvmloader.c when assigning disk controller to a guest, Zhang, Li

Next by Date:

[Xen-devel] Re: [PATCH 00 of 36] x86/paravirt: groundwork for 64-bit Xen support, Jeremy Fitzhardinge

Previous by Thread:

[Xen-devel] [patch][vtd] Remove ASSERT in hvmloader.c when assigning disk controller to a guest, Zhang, Li

Next by Thread:

[Xen-devel] RE: [patch][vtd] Remove ASSERT in hvmloader.c when assigning disk controller to a guest, Zhang, Li

Indexes:

[Date] [Thread] [Top] [All Lists]

WARNING - OLD ARCHIVES

xen-devel

[Xen-devel] Re: [patch][vtd] Remove ASSERT in hvmloader.c when assigning