WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] [Patch] XendOptionsSMF, missing get_config_value method on S

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] [Patch] XendOptionsSMF, missing get_config_value method on Solaris
From: Juergen Keil <jk@xxxxxxxx>
Date: Fri, 6 Jun 2008 16:52:07 +0200 (CEST)
Cc: John Levon <levon@xxxxxxxxxxxxxxxxx>
Delivery-date: Fri, 06 Jun 2008 07:53:22 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Reply-to: Juergen Keil <jk@xxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
John Levon wrote:

> Instead, I think get_keymap() needs to use get_config_string().

Here's an alternate version of my previous patch,
using get_config_string for options that are strings.
get_config_value missing in XendOptionsSMF instance, breaks xend on Solaris

On Solaris, interface XendOptionsSMF doesn't define a get_config_value
method. We only have XendOptionsSMF.get_config_string.

Class XendOptionsFile has both: get_config_value and get_config_string.
And get_config_string is an alias for get_config_value.

This breaks the original code for get_keymap() on a solaris dom0:

    def get_keymap(self):
        return self.get_config_value('keymap', None)

[2008-06-06 14:12:18 1350] ERROR (SrvDaemon:347) Exception starting xend 
(XendOptionsSMF instance has no attribute 'get_config_value')


Use get_config_string for 'keymap' and 'resource-label-change-script'.


Signed-off-by: Juergen Keil <jk@xxxxxxxx>

diff --git a/tools/python/xen/xend/XendOptions.py 
b/tools/python/xen/xend/XendOptions.py
--- a/tools/python/xen/xend/XendOptions.py
+++ b/tools/python/xen/xend/XendOptions.py
@@ -330,10 +330,10 @@
                                      self.vncpasswd_default)
 
     def get_keymap(self):
-        return self.get_config_value('keymap', None)
+        return self.get_config_string('keymap', None)
 
     def get_resource_label_change_script(self):
-        s = self.get_config_value('resource-label-change-script')
+        s = self.get_config_string('resource-label-change-script')
         if s:
             result = s.split(" ")
             result[0] = os.path.join(osdep.scripts_dir, result[0])
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>