[Xen-devel] [Patch] XendOptionsSMF, missing get_config_value method on Solaris

[Juergen Keil <jk@xxxxxxxx>]

John Levon wrote:

> Instead, I think get_keymap() needs to use get_config_string().

Here's an alternate version of my previous patch,
using get_config_string for options that are strings.

get_config_value missing in XendOptionsSMF instance, breaks xend on Solaris

On Solaris, interface XendOptionsSMF doesn't define a get_config_value
method. We only have XendOptionsSMF.get_config_string.

Class XendOptionsFile has both: get_config_value and get_config_string.
And get_config_string is an alias for get_config_value.

This breaks the original code for get_keymap() on a solaris dom0:

    def get_keymap(self):
        return self.get_config_value('keymap', None)

[2008-06-06 14:12:18 1350] ERROR (SrvDaemon:347) Exception starting xend 
(XendOptionsSMF instance has no attribute 'get_config_value')


Use get_config_string for 'keymap' and 'resource-label-change-script'.


Signed-off-by: Juergen Keil <jk@xxxxxxxx>

diff --git a/tools/python/xen/xend/XendOptions.py 
b/tools/python/xen/xend/XendOptions.py
--- a/tools/python/xen/xend/XendOptions.py
+++ b/tools/python/xen/xend/XendOptions.py
@@ -330,10 +330,10 @@
                                      self.vncpasswd_default)
 
     def get_keymap(self):
-        return self.get_config_value('keymap', None)
+        return self.get_config_string('keymap', None)
 
     def get_resource_label_change_script(self):
-        s = self.get_config_value('resource-label-change-script')
+        s = self.get_config_string('resource-label-change-script')
         if s:
             result = s.split(" ")
             result[0] = os.path.join(osdep.scripts_dir, result[0])

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel