WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [Patch] XendOptionsSMF, missing get_config_value method

To: Juergen Keil <jk@xxxxxxxx>
Subject: Re: [Xen-devel] [Patch] XendOptionsSMF, missing get_config_value method on Solaris
From: John Levon <levon@xxxxxxxxxxxxxxxxx>
Date: Fri, 6 Jun 2008 14:12:20 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Fri, 06 Jun 2008 06:12:59 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20080606125714.0DE1D4C95B@xxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20080606125714.0DE1D4C95B@xxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.9i
On Fri, Jun 06, 2008 at 02:57:13PM +0200, Juergen Keil wrote:

> On Solaris, xend XendOptions.py uses an additional interface XendOptionsSMF.
> This allows xend configuration via Solaris SMF as well as the config file.
> (Added by changeset 13407).
> 
> Problem: XendOptionsSMF doesn't define a get_config_value; but these
> is get_config_string.  The code in XendOptions.py needs both; 
> get_keymap() needs get_config_value.

I'm not sure about this: SMF values are always typed and there's really
no such thing as just a value. Instead, I think get_keymap() needs to
use get_config_string(). Note it's the only base class routine that does
this.

regards
john

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel