WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] [PATCH] Fix blkif.py for virsh start

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] [PATCH] Fix blkif.py for virsh start
From: Masaki Kanno <kanno.masaki@xxxxxxxxxxxxxx>
Date: Tue, 03 Jun 2008 18:39:54 +0900
Delivery-date: Tue, 03 Jun 2008 02:40:38 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Hi,

I defined a cdrom to a guest domain as follows.

  ",hdc:cdrom,r"

When the guest domain was created by using xm create command, uname 
of the cdrom was ''.  Then creating the guest domain succeeded.

[2008-06-03 15:23:41 xend.XendDomainInfo 25956] DEBUG (XendDomainInfo:200) 
XendDomainInfo.create(['vm', ['name', 'rhel5.2ga_hvm_lvol1'], 
<<snip>>
['device', ['vbd', ['uname', ''], ['dev', 'hdc:cdrom'], ['mode', 'r']]], 
<<snip>>


But, when the guest domain was created by using virsh start command, 
uname of the cdrom was None.  Then creating the guest domain failed. 

[2008-06-03 15:22:10 xend.XendDomainInfo 25559] DEBUG (XendDomainInfo:200) 
XendDomainInfo.create(['vm', ['name', 'rhel5.2ga_hvm_lvol1'], 
<<snip>>
['device', ['vbd', ['dev', 'hdc:cdrom'], ['mode', 'r']]], 
<<snip>>


This patch fixes to be able to create guest domains by both xm create 
command and virsh start command.

FYI:
"if uname is None:" --> "if uname == '':" --> "if not uname:"
   till CS#17625             current           by this patch


Signed-off-by: Masaki Kanno <kanno.masaki@xxxxxxxxxxxxxx>

Best regards,
 Kan

Attachment: cdrom.patch
Description: Binary data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] [PATCH] Fix blkif.py for virsh start, Masaki Kanno <=