RE: [Xen-devel] [PATCH 1/9] Add cpu idle pwr mgmt to xen

["Tian, Kevin" <kevin.tian@xxxxxxxxx>]

One thing kicking me just now is, whether Linux address check
style can be used here by temporarily increasing address limit
in compat logic to bypass relative check in common code? I
didn't see obvious benefit to reserve a guest virtual addr range
and let each component to manage internal allocation themselves.
Linux style seems simpler and compat logic can just use xmalloc
to create native copy to reduce xlat complexity.

Thanks,
Kevin


>From: Keir Fraser
>Sent: 2008年4月30日 16:54
>
>On 30/4/08 08:22, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:
>
>>>>> "Wei, Gang" <gang.wei@xxxxxxxxx> 30.04.08 05:27 >>>
>>> Revising done according to Jan's comments. Resend.
>> 
>> Thanks. Unfortunately you now use a static (but not per-CPU) 
>variable -
>> while I understand that it is expected that the call is done 
>just once, I
>> don't think this is a good thing to do.
>
>Why is the variable even non-local? Is it just to make the 
>xlat_malloc*()
>interfaces simpler? It's a false simplification if so, and I 
>think you'd be
>better making the variable an explicit parameter to those functions.
>
>Also I agree with Jan regarding non-ISO C usage of loop-header variable
>declarations (don't do it) and also you should check copy_from_guest*()
>return values and return -EFAULT where appropriate. His 
>comment regarding
>explicit padding or use of uint32_t in your public bitfield 
>also sounds good
>to me.
>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel