WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] [PATCH 1/9] Add cpu idle pwr mgmt to xen

>>> "Wei, Gang" <gang.wei@xxxxxxxxx> 26.04.08 11:55 >>>
>Revised according to Keir's comments. Resubmit.

Some comments regarding the compat guest handling: You cannot
validly set_xen_guest_handle() on space coming from xmalloc. It is
the purpose of the per-vCPU argument translation page to deal with
that (i.e. the translated arguments go into that page, subject to your
own management of how you assign space for the individual (sub-)
hypercall's arguments).

Further, you shouldn't manually copy fields, this should be done
through the machine generated macros in xen/include/compat/xlat.h,
which would require you to add the structures needing translation to
xen/include/xlat.lst.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel