WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] linux/balloon: don't allow ballooning down a dom

To: Jan Beulich <jbeulich@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] linux/balloon: don't allow ballooning down a domain below a reasonable limit
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Sat, 05 Apr 2008 22:39:38 +0100
Cc: Ky Srinivasan <KSrinivasan@xxxxxxxxxx>, Kurt Garloff <garloff@xxxxxxx>
Delivery-date: Sat, 05 Apr 2008 14:40:28 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <47F6604E.76E4.0078.0@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AciXZYw3yxFPWgNYEd2F1gAWy6hiGQ==
Thread-topic: [Xen-devel] [PATCH] linux/balloon: don't allow ballooning down a domain below a reasonable limit
User-agent: Microsoft-Entourage/11.4.0.080122
On 4/4/08 16:07, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:

> +#ifndef CONFIG_XEN
> +#define max_pfn totalram_pages
> +#endif

This is silly. We modify totalram_pages as we balloon up and down, so this
really isn't very max_pfn-like after ballooning gets under way.

So I've applied the patch but I made it a no-op if !defined(CONFIG_XEN),
until/unless someone comes up with a better alternative to totalram_pages.
Possibly just latching totalram_pages when we install the balloon driver
would be sufficient?

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel