WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] grant tables and HVM+PV

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] grant tables and HVM+PV
From: John Levon <levon@xxxxxxxxxxxxxxxxx>
Date: Fri, 28 Mar 2008 16:50:22 +0000
Delivery-date: Fri, 28 Mar 2008 09:51:11 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.9i
This changeset:

changeset:   15606:17820aa1b2c0
user:        Keir Fraser <keir.fraser@xxxxxxxxxx>
date:        Fri Dec 14 11:58:37 2007 +0000
summary:     hvm: Remove duplicate assignment of __HYPERVISOR_grant_table_op in

Has broken our HVM PV drivers. Previously we were using:

520         if ((HYPERVISOR_grant_table_op(GNTTABOP_setup_table, pset, 1) != 0) 
||
521             (pset->status != 0)) { 

even on HVM. Now, this isn't actually necessary (stuff works fine with
the call nop'd out, presumably due to the auto-sizing), but I wonder why the
only grant op allowed is _query_size? IE what's the status of grant
table code on HVM/PV? Is it just disabled because no compat audit has
been done, or what?

regards
john

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>