WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: Illegal PV kernel pfm/pfn translations on PROT_NONE iore

To: "Stephen C. Tweedie" <sct@xxxxxxxxxx>
Subject: [Xen-devel] Re: Illegal PV kernel pfm/pfn translations on PROT_NONE ioremaps
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Thu, 20 Mar 2008 11:39:26 +0000
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxxxx>
Delivery-date: Thu, 20 Mar 2008 04:41:03 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C407115D.1E26E%keir.fraser@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AciJ8lfolrMeWPXlEdyyLQAX8io7RQAjLTgd
Thread-topic: Illegal PV kernel pfm/pfn translations on PROT_NONE ioremaps
User-agent: Microsoft-Entourage/11.4.0.080122
On 19/3/08 18:52, "Keir Fraser" <keir.fraser@xxxxxxxxxxxxx> wrote:

>> Yep.  There are a number of bits that could be used: for example, I
>> don't think PROT_WRITE is ever going to be set on a PROT_NONE page,
>> either.
> 
> My point is the flag would be set even when the protection is not PROT_NONE.
> It has other uses beyond fixing this bug.
> 
> I might look into doing this myself as I think it is probably the best fix for
> this issue.

...and the issue is now fixed (changeset 488) in
http://xenbits.xensource.com/staging/linux-2.6.18-xen.hg

The patch is a minimal one given the approach of using a new _PAGE_IO flag.
For example, pte_pfn() probably no longer needs to use mfn_to_local_pfn()
and could use the simpler and faster mfn_to_pfn() instead. But that belongs
in a separate patch.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel