Re: [Xen-devel][PATCH][RFC] Supporting Enlightened Windows 2008 Server

["Ky Srinivasan" <ksrinivasan@xxxxxxxxxx>]

>>> On Wed, Mar 5, 2008 at  5:28 PM, in message
<20080305222828.GH19306@xxxxxxxxxx>, "Daniel P. Berrange" <berrange@xxxxxxxxxx>
wrote: 
> On Wed, Mar 05, 2008 at 03:15:19PM -0700, Ky Srinivasan wrote:
>> I am attaching updated versions of the patches that I posted a couple 
>> of weeks ago. These  have been merged up to the current unstable tip: 
>> changeset 17186:854b0704962b
>> 
>> These patches have been tested on the unstable tip.
> 
> I'm not expert enough to comment on the HV extension implementation itself,
> but in terms of the userspace  side, the user visible configuration file 
> option 'extid=1' is pretty unpleasant.  It is akin to a 'magic constant'
> in C code - no understandable meaning at all.

Agreed; I could make the extension tag more descriptive.

Regards,

K. Y

> 
> I'd like to see it accept a named extension type - if its possible to
> have multiple extensions per guest, then using a list instead of a scalar
> would be better. So how about something closer to
> 
>   extensions = [ "win2k8" ]
> 
>> +gopts.var('extid', val='EXTID',
>> +          fn=set_int, default=0,
>> +          use="Specify extention ID for a HVM domain.")
>> +
> 
> And this help message could list the valid extension names
> 
> 
> Regards,
> Dan.




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel