 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH][HVM] pass-through PCI device hotplug support
| To: | "Daniel P. Berrange" <berrange@xxxxxxxxxx>, "Zhai, Edwin" <edwin.zhai@xxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH][HVM] pass-through PCI device hotplug support |
| From: | Keir Fraser <Keir.Fraser@xxxxxxxxxxxx> |
| Date: | Thu, 24 Jan 2008 18:08:44 +0000 |
| Cc: | xen-devel@xxxxxxxxxxxxxxxxxxx |
| Delivery-date: | Thu, 24 Jan 2008 10:10:03 -0800 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxx |
| In-reply-to: | <20080124180656.GC2400@xxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| Thread-index: | AchetCgaZvLnjcqnEdyD1QAX8io7RQ== |
| Thread-topic: | [Xen-devel] [PATCH][HVM] pass-through PCI device hotplug support |
| User-agent: | Microsoft-Entourage/11.3.6.070618 |
On 24/1/08 18:06, "Daniel P. Berrange" <berrange@xxxxxxxxxx> wrote: > IMHO we shouldn't have a 'd' on the front of the command names. VT-d is a > vendor specific implementation whose nomenculture doesn't need to be exposed > to users. In addition the existing block & network hotplug commands use > 'attach' and 'detach' for their command names. So for sake of consistency > I'd recommend command names of: > > pci-list > pci-attach > pci-detach > > I think it is useful to use the same unique naming & data for both attach and > detach operations. So if we use a (bus,slot,func) triple for attachment, I > think we should use the same (bus,slot,func) triple for detachment too, > rather than having to make apps / users lookup the dynamically-allocated > 'ID' value for the device. Seconded. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [Xen-devel] [PATCH][HVM] pass-through PCI device hotplug support, Daniel P. Berrange |
|---|---|
| Next by Date: | RE: [Xen-devel] [VTD][PATCH] interrupt remapping patch for xen 3.3, Kay, Allen M |
| Previous by Thread: | Re: [Xen-devel] [PATCH][HVM] pass-through PCI device hotplug support, Daniel P. Berrange |
| Next by Thread: | Re: [Xen-devel] [PATCH][HVM] pass-through PCI device hotplug support, Zhai, Edwin |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
