WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] x86_emulate(): forgot to generate_exception_if() for 0xff?

To: <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] x86_emulate(): forgot to generate_exception_if() for 0xff?
From: "Liu, Eric E" <eric.e.liu@xxxxxxxxx>
Date: Wed, 19 Dec 2007 17:34:03 +0800
Delivery-date: Wed, 19 Dec 2007 01:35:51 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AchCIkspvq503+fcSaGc/QzK2IvTbA==
Thread-topic: x86_emulate(): forgot to generate_exception_if() for 0xff?
Hi all,
In arch/x86/x86_emulate.c: x86_emulate():
   1716     case 0xfe: /* Grp4 */
   1717         generate_exception_if((m odrm_reg & 7) >= 2, EXC_UD);
   1718     case 0xff: /* Grp5 */
   1719         switch ( modrm_reg & 7 )
   1720         {
   1721         case 0: /* inc */
   1722             emulate_1op("inc", dst, _regs.eflags);
   1723             break;
   1724         case 1: /* dec */
   1725             emulate_1op("dec", dst, _regs.eflags);
   1726             break;

Here we only check 0xfe for "reg >= 2"? I think we should also check
0xff -- we should swap line 1717 and 1718?

Thanks!
--Eric (Liu, Feng)

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>