WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] compile error of HVM pv drivers

To: "Zhao, Yunfeng" <yunfeng.zhao@xxxxxxxxx>, Kieran Mansley <kmansley@xxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] compile error of HVM pv drivers
From: Keir Fraser <keir@xxxxxxxxxxxxx>
Date: Mon, 30 Jul 2007 16:05:23 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Mon, 30 Jul 2007 08:03:16 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <10EA09EFD8728347A513008B6B0DA77AA3EF7B@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcfSuSOEYcsCnj6sEdyq8gAX8io7RQAASASwAAAyeLY=
Thread-topic: [Xen-devel] compile error of HVM pv drivers
User-agent: Microsoft-Entourage/11.3.3.061214
I think you'll find that doesn't fix the problem. The () is there for a
reason.

 K.

On 30/7/07 16:02, "Zhao, Yunfeng" <yunfeng.zhao@xxxxxxxxx> wrote:

> The problem may be from the new changes in
> unmodified_drivers/linux-2.6/compat-include/xen/platform-compat.h
> 
> the following two lines:
> #define netif_tx_lock_bh(dev) (spin_lock_bh(&(dev)->xmit_lock))
> #define netif_tx_unlock_bh(dev) (spin_unlock_bh(&(dev)->xmit_lock))
> should be
> #define netif_tx_lock_bh(dev) (spin_lock_bh(&dev->xmit_lock))
> #define netif_tx_unlock_bh(dev) (spin_unlock_bh(&dev->xmit_lock))
> "()" is useless for dev.
> 
> Thanks
> Yunfeng
> 
> 
> 
>> -----Original Message-----
>> From: Keir Fraser [mailto:keir@xxxxxxxxxxxxx]
>> Sent: 2007年7月30日 22:52
>> To: Kieran Mansley; Zhao, Yunfeng
>> Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
>> Subject: Re: [Xen-devel] compile error of HVM pv drivers
>> 
>> On 30/7/07 15:47, "Kieran Mansley" <kmansley@xxxxxxxxxxxxxx> wrote:
>> 
>>> In that case replacing the calls (there are two in that file) to
>>> netif_tx_lock_bh() with:
>>> 
>>>  spin_lock_bh(&vif_state->np->netdev->xmit_lock);
>>> 
>>> And similarly the calls to netif_tx_unlock_bh() with spin_unlock_bh(),
>>> may solve your problem.
>>> 
>>> If this works for you I'll make a patch that uses the kernel version to
>>> decide which is appropriate.
>> 
>> Compat issues when building PV-on-HVM drivers are patched up out-of-band in
>> the special
>> unmodified_drivers/linux-2.6/compat-include/xen/platform-compat.h
>> header file.
>> 
>> -- Keir
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel