WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-ia64-devel] Re: [Xen-devel] Re: [Xen-changelog] [linux-2.6.18-xen]

To: Jun Kamada <kama@xxxxxxxxxxxxxx>, Keir Fraser <keir@xxxxxxxxxxxxx>
Subject: [Xen-ia64-devel] Re: [Xen-devel] Re: [Xen-changelog] [linux-2.6.18-xen] Add "#ifdefARCH_HAS_DEV_MEM" to archtecture specific file_operations.
From: Akio Takebe <takebe_akio@xxxxxxxxxxxxxx>
Date: Fri, 13 Jul 2007 11:42:02 +0900
Cc: Isaku Yamahata <yamahata@xxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx, Hollis Blanchard <hollisb@xxxxxxxxxx>, xen-ia64-devel <xen-ia64-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Thu, 12 Jul 2007 19:40:15 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20070712193743.23F0.KAMA@xxxxxxxxxxxxxx>
List-help: <mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-id: Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
List-post: <mailto:xen-ia64-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20070711143610.7F6E.KAMA@xxxxxxxxxxxxxx> <C2BA68D5.12413%keir@xxxxxxxxxxxxx> <20070712193743.23F0.KAMA@xxxxxxxxxxxxxx>
Sender: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx
Hi, Kama, Keir and Isaku

>On Wed, 11 Jul 2007 11:00:37 +0100
>Keir Fraser <keir@xxxxxxxxxxxxx> wrote:
>> The case of building drivers/xen/char/mem.c, yet not defining
>> ARCH_HAS_DEV_MEM, does not seem useful. Who will pick up and use the
>> mem_fops defined by drivers/xen/char/mem.c?
>> 
>> At the very least this seems abusive of ARCH_HAS_DEV_MEM, and you might be
>> better off defining a different macro name? But I think you need to explain
>> to us what it is you're actually trying to achieve.
>
>I would like to deal with the drivers/xen/char/mem.c as follows. How do
>you think about it? It will cause any problem?
>
>- I will post a patch, which removes definition of ARCH_HAS_DEV_MEM, to
>  xen-ia64-devel later.
>- If needed, I will post a revert patch of 
>  "xen-ia64-devel.hg c/s 12544:395aa5609e6d". (Creating the revert patch
>  may be difficult...)
Xen-ia64 already don't need to modify drivers/xen/char/mem.c.
But as you mentioned, current drivers/xen/char/mem.c has some parts
for xen-ia64. So we may need to cleanup drivers/xen/char/mem.c.

I made a attached revert patch of xen-unstablecs12513[1]
(same as xen-ia64 cs12544). Keir, Isaku, how about it?

If the patch is applied, we cannot compile linux-xen-ia64.
But I have a patch of reverting cs12873[2],
if the patch is also applied, we can compile linux-xen-ia64 again.
I think Kama will post this patch to xen-ia64-devel soon.

Signed-off-by: Akio Takebe <takebe_akio@xxxxxxxxxxxxxx>
Signed-off-by: Jun Kamada <kama@xxxxxxxxxxxxxx>

[1] cs12513
http://xenbits.xensource.com/xen-unstable.hg?rev/395aa5609e6d
[2] cs12873
http://xenbits.xensource.com/xen-unstable.hg?rev/e5e6893ec699

Best Regards,

Akio Takebe

Attachment: revert_12513.patch
Description: Binary data

Attachment: revert_12873.patch
Description: Binary data

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel
<Prev in Thread] Current Thread [Next in Thread>