WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Re: [Xen-changelog] [linux-2.6.18-xen] Add "#ifdef ARCH_

To: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Subject: Re: [Xen-devel] Re: [Xen-changelog] [linux-2.6.18-xen] Add "#ifdef ARCH_HAS_DEV_MEM" to archtecture specific file_operations.
From: Jun Kamada <kama@xxxxxxxxxxxxxx>
Date: Wed, 11 Jul 2007 14:44:11 +0900
Cc: kama@xxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx, Hollis Blanchard <hollisb@xxxxxxxxxx>
Delivery-date: Tue, 10 Jul 2007 22:42:17 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C2B514FB.A791%Keir.Fraser@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1183753555.3008.24.camel@basalt> <C2B514FB.A791%Keir.Fraser@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Keir-san and Hollis-san,

On Sat, 07 Jul 2007 10:01:31 +0100
Keir Fraser <Keir.Fraser@xxxxxxxxxxxx> wrote:
> We define it in asm/mach-xen/asm/io.h.
> 
> However, the patch *is* of questionable value. It guards the only non-static
> definition in the file with #ifdef ARCH_HAS_DEV_MEM. Which begs the question
> why you would build the file at all if !ARCH_HAS_DEV_MEM. I'll revert it.

I'm sorry that I had posted the incomplete patch. I will attach a new
one modified. The patch resolves ploblems mentioned above?

Best regards,

-----
Jun Kamada
Linux Technology Development Div.
Server Systems Unit
Fujitsu Ltd.
kama@xxxxxxxxxxxxxx

Attachment: add_ifdef_arch_has_dev_mem.patch
Description: Binary data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>