WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Question regarding SLAB corruption

To: Keir Fraser <keir@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] Question regarding SLAB corruption
From: Roland Dreier <rdreier@xxxxxxxxx>
Date: Mon, 09 Jul 2007 14:26:45 -0700
Authentication-results: sj-dkim-1; header.From=rdreier@xxxxxxxxx; dkim=pass ( sig from cisco.com/sjdkim1004 verified; );
Cc: Lukas Hejtmanek <xhejtman@xxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Tue, 10 Jul 2007 10:11:32 -0700
Dkim-signature: v=0.5; a=rsa-sha256; q=dns/txt; l=764; t=1184016406; x=1184880406; c=relaxed/simple; s=sjdkim1004; h=Content-Type:From:Subject:Content-Transfer-Encoding:MIME-Version; d=cisco.com; i=rdreier@xxxxxxxxx; z=From:=20Roland=20Dreier=20<rdreier@xxxxxxxxx> |Subject:=20Re=3A=20[Xen-devel]=20Question=20regarding=20SLAB=20corruptio n |Sender:=20; bh=aplK2CuVjw9lBqQ0mDsUwUH+XlgAPRDSa8e2ZvaaroY=; b=qt8eVM4lJQ/D7qZVUG+qAAwSSg3Iv/NLy6Usk/YXpgOIzjiOg3AkAZHNzdhm5r9Qm1PsWRU1 NUqF8l/aK3KIKs7DI7AFY+zZwMErEKG4iqkuO/xYsm3cAQ1Etc7fa7/dq7LbjXiAuprBG4/rwg bMo7XVVZMfE2srA1uxiE9WbXc=;
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C2B83D37.A8DF%keir@xxxxxxxxxxxxx> (Keir Fraser's message of "Mon, 09 Jul 2007 19:29:59 +0100")
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <C2B83D37.A8DF%keir@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Gnus/5.1007 (Gnus v5.10.7) XEmacs/21.4.20 (linux)
 > Oh! I take it then that the infiniband driver will call sync_single() on
 > subsections of a mapped region? I haven't seen that behaviour before and it
 > will kill lib/swiotlb.c (the generic Linux swiotlb implementation) just as
 > surely as it does the Xen-specific swiotlb!

 > We could make the swiotlb robust to this treatment, I guess. It will involve
 > initialising all covered io_tlb_orig_addr[] slots rather than just the
 > first.

Does this mean that lib/swiotlb.c's swiotlb_sync_single_range_for_cpu()
and swiotlb_sync_single_range_for_device() are broken?  Given that (as
you say) io_tlb_orig_addr[] only gets one slot filled in at the end of
map_single(), I don't see any way it could work if more than one page
is mapped.

 - R.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel