|   | 
      | 
  
  
      | 
      | 
  
 
     | 
    | 
  
  
     | 
    | 
  
  
    |   | 
      | 
  
  
    | 
         
xen-devel
[Xen-devel] [Patch v3] static,	__init and __initdata symbols in machine_
 
Some symbols in machine_kexec.c really ought to be static and,
marked __init or __initdata.
Signed-off-by: Simon Horman <horms@xxxxxxxxxxxx>
--- 
 linux-2.6-xen-sparse/drivers/xen/core/machine_kexec.c |   10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
Update: put __init somehere a bit less silly for
        the struct resource symbols
Update: Use __initdata instead of __init for variables,
        as suggested by Keir Fraser
Index: 
xen-ia64-unstable.hg/linux-2.6-xen-sparse/drivers/xen/core/machine_kexec.c
===================================================================
--- 
xen-ia64-unstable.hg.orig/linux-2.6-xen-sparse/drivers/xen/core/machine_kexec.c 
    2007-05-16 16:37:04.000000000 +0900
+++ xen-ia64-unstable.hg/linux-2.6-xen-sparse/drivers/xen/core/machine_kexec.c  
2007-05-16 16:44:26.000000000 +0900
@@ -11,11 +11,11 @@
 extern void machine_kexec_setup_load_arg(xen_kexec_image_t *xki, 
                                         struct kimage *image);
 
-int xen_max_nr_phys_cpus;
-struct resource xen_hypervisor_res;
-struct resource *xen_phys_cpus;
+static int __initdata xen_max_nr_phys_cpus;
+static struct resource __initdata xen_hypervisor_res;
+static struct resource __initdata *xen_phys_cpus;
 
-void xen_machine_kexec_setup_resources(void)
+void __init xen_machine_kexec_setup_resources(void)
 {
        xen_kexec_range_t range;
        struct resource *res;
@@ -104,7 +104,7 @@ void xen_machine_kexec_setup_resources(v
        return;
 }
 
-void xen_machine_kexec_register_resources(struct resource *res)
+void __init xen_machine_kexec_register_resources(struct resource *res)
 {
        int k;
 
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
 |   
 
| <Prev in Thread] | 
Current Thread | 
[Next in Thread>
 |  
- [Xen-devel] static and __init symbols in machine_kexec.c, Simon Horman
- [Xen-devel] [Patch v2] static and __init symbols in machine_kexec.c, Simon Horman
- Re: [Xen-devel] [Patch v2] static and __init symbols in	machine_kexec.c, Keir Fraser
- Re: [Xen-devel] [Patch v2] static and __init symbols in	machine_kexec.c, Simon Horman
 - Re: [Xen-devel] [Patch v2] static and __init symbols in	machine_kexec.c, Simon Horman
 
- [Xen-devel] [Patch v3] static,	__init and __initdata symbols in machine_kexec.c,
Simon Horman <=
 - [Xen-devel] Re: [Patch v3] static, __init and __initdata symbols in	machine_kexec.c, Ian Campbell
 - [Xen-devel] Re: [Patch v3] static,	__init and __initdata symbols in machine_kexec.c, Simon Horman
 - [Xen-devel] Re: [Patch v3] static, __init and __initdata symbols in machine_kexec.c, Keir Fraser
 - [Xen-devel] Re: [Patch v3] static,	__init and __initdata symbols in machine_kexec.c, Simon Horman
 
  
  
  
- [Xen-devel] [Patch v4] static,	__init and __initdata symbols in machine_kexec.c, Simon Horman
 
 
 |  
  
 | 
    | 
  
  
    |   | 
    |