WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 		  
Home Products Support Community News
 
   
 

xen-devel

[Top] [All Lists]
<prev [Date] next>
[Advanced]
 <prev [Thread] next>

Re: [Xen-devel] [Patch v2] static and __init symbols in machine_kexec.c

from [Keir Fraser] [Permanent Link][Original]
To: Simon Horman <horms@xxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [Patch v2] static and __init symbols in machine_kexec.c
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Wed, 16 May 2007 08:21:41 +0100
Cc: Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>
Delivery-date: Wed, 16 May 2007 00:18:07 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <1179298159.23300.1@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AceXitlHF6SAygN+EdyYUgAWy6hiGQ==
Thread-topic: [Xen-devel] [Patch v2] static and __init symbols in machine_kexec.c
User-agent: Microsoft-Entourage/11.3.3.061214 


On 16/5/07 07:49, "Simon Horman" <horms@xxxxxxxxxxxx> wrote:

> Curiously, making xen_max_nr_phys_cpus __init causes a section missmatch
> error at compile time. I guess this is to do with the way global ints
> are handled. I confirmed that its consistent across x86_32, x86_64 and
> ia64. So I guess its ok to leave it as is.

What if you make it __initdata, as it (and the other data variables) should
be?

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
[More with this subject...]
<Prev in Thread] Current Thread [Next in Thread>
Previous by Date:  [Xen-devel] [Patch v2] static and __init symbols in machine_kexec.c, Simon Horman
Next by Date:  Re: [Xen-devel] [Patch v2] static and __init symbols in machine_kexec.c, Simon Horman
Previous by Thread:  [Xen-devel] [Patch v2] static and __init symbols in machine_kexec.c, Simon Horman
Next by Thread:  Re: [Xen-devel] [Patch v2] static and __init symbols in machine_kexec.c, Simon Horman
Indexes:  [Date] [Thread] [Top] [All Lists]
 
   

Copyright , Citrix Systems Inc. All rights reserved. Legal and Privacy