WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] trap bounce flags

To: Jan Beulich <jbeulich@xxxxxxxxxx>, Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] trap bounce flags
From: Keir Fraser <keir@xxxxxxxxxxxxx>
Date: Wed, 25 Apr 2007 11:16:46 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 25 Apr 2007 03:15:33 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C254E789.DCFB%keir@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AceHIeKsIUUMtvMVEduM1gAX8io7RQAAPFkq
Thread-topic: [Xen-devel] trap bounce flags
User-agent: Microsoft-Entourage/11.3.3.061214
On 25/4/07 11:10, "Keir Fraser" <keir@xxxxxxxxxxxxx> wrote:

>> - from the above, why is it that only the lower byte (if anything) needs
>> clearing?
> 
> Really it's a one-byte field: it's consistently treated that way in asm
> code. The upper byte is always zero. We should probably make the field
> explicitly uint8_t. Agree?

FYI, we need to clear that field usually because the contents are one-shot
but the structure itself is permanent and checked on every return to guest.
A non-zero flags field is what we use to indicate whether the structure is
'primed' or not. So the passing in of a different, non-one-shot, structure
on the direct-int80 path is a bit abusive of the interface. But I think we
can live with it if we reset the flags field manually and include a comment.
:-)

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel