WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] linux: simplify and perform checking of multical

To: Jan Beulich <jbeulich@xxxxxxxxxx>, Keir Fraser <keir@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] linux: simplify and perform checking of multicall status
From: Keir Fraser <keir@xxxxxxxxxxxxx>
Date: Thu, 05 Apr 2007 10:15:23 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 05 Apr 2007 02:14:24 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <4614D6B2.76E4.0078.0@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acd3YvCSLtoP2+NWEduTxgAX8io7RQ==
Thread-topic: [Xen-devel] [PATCH] linux: simplify and perform checking of multicall status
User-agent: Microsoft-Entourage/11.2.5.060620


On 5/4/07 10:00, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:

> Huh, indeed. And perhaps it should (give the rest of the function) even
> be
> 
> if (unlikely(rc < 0))
> return rc;
> BUG_ON(rc);
> 
> (i.e. so that positive return values indicate the failed slot, negative ones
> indicate a failure of the multicall itself).

Makes sense. I'll merge that in.

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>