 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH] linux: simplify and perform checking of multical
| To: | "Keir Fraser" <keir@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH] linux: simplify and perform checking of multicall status |
| From: | "Jan Beulich" <jbeulich@xxxxxxxxxx> |
| Date: | Thu, 05 Apr 2007 10:00:02 +0100 |
| Cc: | xen-devel@xxxxxxxxxxxxxxxxxxx |
| Delivery-date: | Thu, 05 Apr 2007 01:58:03 -0700 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxx |
| In-reply-to: | <C23A7202.CCED%keir@xxxxxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| References: | <4607FAD3.76E4.0078.0@xxxxxxxxxx> <C23A7202.CCED%keir@xxxxxxxxxxxxx> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
>>> Keir Fraser <keir@xxxxxxxxxxxxx> 05.04.07 10:29 >>>
>On 26/3/07 15:54, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:
>
>> +static inline int
>> +HYPERVISOR_multicall_check(
>> + multicall_entry_t *call_list, int nr_calls,
>> + const unsigned long *rc_list)
>> +{
>> + int rc = HYPERVISOR_multicall(call_list, nr_calls);
>> +
>> + if (unlikely(rc == 0))
>> + return rc;
>
>ITYM unlikely(rc != 0)?
Huh, indeed. And perhaps it should (give the rest of the function) even
be
if (unlikely(rc < 0))
return rc;
BUG_ON(rc);
(i.e. so that positive return values indicate the failed slot, negative ones
indicate a failure of the multicall itself).
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [Xen-devel] question about the meaning of auto-translated mode and no overlay mode, tgh |
|---|---|
| Next by Date: | Re: [Xen-devel] [PATCH] linux: simplify and perform checking of multicall status, Keir Fraser |
| Previous by Thread: | Re: [Xen-devel] [PATCH] linux: simplify and perform checking of multicall status, Keir Fraser |
| Next by Thread: | Re: [Xen-devel] [PATCH] linux: simplify and perform checking of multicall status, Keir Fraser |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
