This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] pciback: check function return values

To: Jan Beulich <jbeulich@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] pciback: check function return values
From: Keir Fraser <keir@xxxxxxxxxxxxx>
Date: Wed, 28 Mar 2007 14:41:01 +0100
Delivery-date: Wed, 28 Mar 2007 06:40:05 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <460A7D47.76E4.0078.0@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcdxPrkO91MyUt0xEduq7wAX8io7RQ==
Thread-topic: [Xen-devel] [PATCH] pciback: check function return values
User-agent: Microsoft-Entourage/

On 28/3/07 13:35, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:

> .. of functions declared with __must_check post-2.6.18.
> (As a note - I'm getting the impression that when used as a module, pciback
> appears to have a number of memory leaks).
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>

Where is the mystery pciback_exit() function defined? You use it but don't
provide an implementation.

 -- Keir

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>