This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] pciback: restore PCI BARs on D3->D0 transition

To: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] pciback: restore PCI BARs on D3->D0 transition
From: Alex Williamson <alex.williamson@xxxxxx>
Date: Mon, 26 Mar 2007 14:23:13 -0600
Delivery-date: Mon, 26 Mar 2007 13:22:18 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <1174937343.20923.38.camel@bling>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: OSLO R&D
References: <1174937343.20923.38.camel@bling>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Mon, 2007-03-26 at 13:29 -0600, Alex Williamson wrote:
> However, we obviously can't expect PCI devices to work without their
> BARs properly programmed.  The patch below adds a call to
> pci_restore_bars() as a workaround until we can figure out why the PCI
> code doesn't do this for us.  Thanks,

   From what I can gather, it seems when a driver induces a transition
to D3, its expected to use pci_save_state() and pci_restore_state().  I
don't think we necessarily need to go to that extent for pciback, but it
does appear to be pciback's responsibility to restore some state on the
card when transitioning out of D3, since it is effectively the driver
for the device.  So, I think the pci_restore_bars() call and the patch I
sent previously are correct.  Thanks,


Alex Williamson                             HP Open Source & Linux Org.

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>