[Xen-devel] [PATCH] pciback: restore PCI BARs on D3->D0 transition

[Alex Williamson <alex.williamson@xxxxxx>]

   Ever since xen-unstable cset 14308 ("pci back: Fix registration of of
filters on subsections of config space") I've been getting an MCA on the
*2nd* boot of a driver domain using an e1000 NIC.  Cset 14308 allowed
the proper setup of the PM control registers, so the NIC is put in the
D3 power state when the driver domain shuts down.  Unfortunately,
pci_set_power_state() won't restore the BARs on a D3hot/cold to D0
transition.  There are some comments in this upstream cset about why
that is:

http://www.kernel.org/hg/linux-2.6/rev/8f33e29c89a7

However, we obviously can't expect PCI devices to work without their
BARs properly programmed.  The patch below adds a call to
pci_restore_bars() as a workaround until we can figure out why the PCI
code doesn't do this for us.  Thanks,

        Alex

Signed-off-by: Alex Williamson <alex.williamson@xxxxxx>
---

diff -r 56caf0e37e6a 
linux-2.6-xen-sparse/drivers/xen/pciback/conf_space_capability_pm.c
--- a/linux-2.6-xen-sparse/drivers/xen/pciback/conf_space_capability_pm.c       
Mon Mar 26 10:10:31 2007 -0600
+++ b/linux-2.6-xen-sparse/drivers/xen/pciback/conf_space_capability_pm.c       
Mon Mar 26 13:13:23 2007 -0600
@@ -33,7 +33,7 @@ static int pm_ctrl_write(struct pci_dev 
 {
        int err;
        u16 cur_value;
-       pci_power_t new_state;
+       pci_power_t new_state, old_state;
 
        /* Handle setting power state separately */
        new_state = (pci_power_t)(new_value & PCI_PM_CTRL_STATE_MASK);
@@ -52,9 +52,20 @@ static int pm_ctrl_write(struct pci_dev 
 
        /* Let pci core handle the power management change */
        dev_dbg(&dev->dev, "set power state to %x\n", new_state);
+       old_state = dev->current_state;
        err = pci_set_power_state(dev, new_state);
        if (err)
                err = PCIBIOS_SET_FAILED;
+
+       /*
+        * Linux does not currently restore the BARs on a transition from
+        * D3hot/cold to D0.  Fixup here.
+        */
+       if (new_state == PCI_D0 &&
+           (old_state == PCI_D3hot || old_state == PCI_D3cold)) {
+               if (!(cur_value & PCI_PM_CTRL_NO_SOFT_RESET))
+                       pci_restore_bars(dev);
+       }
 
       out:
        return err;



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel