This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] Fwd: Re: struct page field arrangement

To: Jan Beulich <jbeulich@xxxxxxxxxx>, Keir Fraser <keir@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] Fwd: Re: struct page field arrangement
From: Keir Fraser <keir@xxxxxxxxxxxxx>
Date: Fri, 16 Mar 2007 14:13:13 +0000
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Fri, 16 Mar 2007 07:12:55 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <45FAADF9.76E4.0078.0@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acdn1Tupegw1SNPIEduhtwAX8io7RQ==
Thread-topic: [Xen-devel] Fwd: Re: struct page field arrangement
User-agent: Microsoft-Entourage/
On 16/3/07 13:47, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:

> Btw., another question that made me wonder already when doing the
> original patch: why is it that x86-64 properly uses locking for mm_pin_all(),
> yet i386 doesn't need to?

Neither needs to. Well, assuming you're not using CONFIG_PREEMPT. :-)

Either we are in stop_machine context, or we have offlined all other CPUs
via cpu hotplug. In the absence of involuntary preemption it's therefore
safe to proceed without locking. But probably inadvisable (we'd like to
support full CONFIG_PREEMPT sometime in the future)... I think the 386 code
should be changed to match x86/64.

 -- Keir

Xen-devel mailing list