This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] Fwd: Re: struct page field arrangement

To: Jan Beulich <jbeulich@xxxxxxxxxx>, Keir Fraser <keir@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] Fwd: Re: struct page field arrangement
From: Keir Fraser <keir@xxxxxxxxxxxxx>
Date: Thu, 01 Mar 2007 13:42:04 +0000
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 01 Mar 2007 05:41:23 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <45E6DA3F.76E4.0078.0@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcdcB2V0pBihAsf6EduJ9AAX8io7RQ==
Thread-topic: [Xen-devel] Fwd: Re: struct page field arrangement
User-agent: Microsoft-Entourage/

On 1/3/07 12:50, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:

> I didn't check what private is being used for - while it can't be used for
> PageForeign's destructor pointer, perhaps netback could use that one
> rather than index? Or, even more likely, netback could use mapping if
> PageForeign was switched over to index (while mapping overlays ptl, that
> is benign to netback as it's not dealing with pte pages). But of course,
> this requires thorough auditing of other uses of index.

Since PageForeign is only used for pagetables (for which you checked ->index
should be okay) and for skbuff data (where we already use ->index in
netback) then changing PageForeign to put the callback in ->index should be

 -- Keir

Xen-devel mailing list