|
xen-devel
[Xen-devel] Re: [RFC] Arp announce (for Xen)
|
To: |
shemminger@xxxxxxxxxxxxxxxxxxxx |
|
Subject: |
[Xen-devel] Re: [RFC] Arp announce (for Xen) |
|
From: |
David Miller <davem@xxxxxxxxxxxxx> |
|
Date: |
Mon, 05 Mar 2007 20:35:36 -0800 (PST) |
|
Cc: |
zach@xxxxxxxxxx, jeremy@xxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx, jeff@xxxxxxxxxx, ian.pratt@xxxxxxxxxxxxx, ak@xxxxxx, netdev@xxxxxxxxxxxxxxx, rusty@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, chrisw@xxxxxxxxxxxx, virtualization@xxxxxxxxxxxxxx, akpm@xxxxxxxxxxxxxxxxxxxx, Christian.Limpach@xxxxxxxxxxxx |
|
Delivery-date: |
Tue, 06 Mar 2007 01:50:49 -0800 |
|
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxx |
|
In-reply-to: |
<20070301173030.754514ec@freekitty> |
|
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
|
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
|
List-post: |
<mailto:xen-devel@lists.xensource.com> |
|
List-subscribe: |
<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
|
List-unsubscribe: |
<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
|
References: |
<20070301164214.4a40bc59@freekitty> <45E7764A.7000100@xxxxxxxx> <20070301173030.754514ec@freekitty> |
|
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
From: Stephen Hemminger <shemminger@xxxxxxxxxxxxxxxxxxxx>
Date: Thu, 1 Mar 2007 17:30:30 -0800
> What about implementing the unused arp_announce flag on the inetdevice?
> Something like the following. Totally untested...
>
> Looks like it either was there (and got removed) or was planned but
> never implemented.
This idea is fine. But:
> + case NETDEV_CHANGEADDR:
> + /* Send gratuitous ARP in case of address change or new device
> */
> + if (IN_DEV_ARP_ANNOUNCE(in_dev))
> + arp_send(ARPOP_REQUEST, ETH_P_ARP,
> + in_dev->ifa_list->ifa_address, dev,
> + in_dev->ifa_list->ifa_address, NULL,
> + dev->dev_addr, NULL);
We'll need to make sure the appropriate 'arp_anounce' address
selection is employed here.
One idea is to change arp_solicit() such that it can be invoked in
this context, or provide a new helper function which will do the
source address selection rules of 'arp_announce' and then invoke
arp_send() as appropriate for us.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
Home