This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] xenbus_dev_write and failed writes

To: John Levon <levon@xxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] xenbus_dev_write and failed writes
From: Keir Fraser <keir@xxxxxxxxxxxxx>
Date: Fri, 02 Mar 2007 16:46:50 +0000
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Fri, 02 Mar 2007 08:46:09 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20070302163535.GA22543@xxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acdc6l+jnfzmCsjdEduwRgAX8io7RQ==
Thread-topic: [Xen-devel] xenbus_dev_write and failed writes
User-agent: Microsoft-Entourage/
On 2/3/07 16:35, "John Levon" <levon@xxxxxxxxxxxxxxxxx> wrote:

> Also, the BUG_ON in xenbusdrv_queue_reply() looks odd to me (in fact the
> whole function does). Are we really guaranteed that a reply message will
> be less than a page size? And it doesn't seem right to just stomp on the
> buffer contents if we wrap right past the consumer value.

Yes, it at least makes sense to discard the data rather than BUG. Actually
we should dynamically allocate up to some rather larger threshold than 4kB.
Will you fix this?

 -- Keir

Xen-devel mailing list