 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] xenbus_dev_write and failed writes
| To: | Keir Fraser <keir@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] xenbus_dev_write and failed writes |
| From: | John Levon <levon@xxxxxxxxxxxxxxxxx> |
| Date: | Fri, 2 Mar 2007 16:35:35 +0000 |
| Cc: | xen-devel@xxxxxxxxxxxxxxxxxxx |
| Delivery-date: | Fri, 02 Mar 2007 08:31:44 -0800 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxx |
| In-reply-to: | <C20E00AE.A839%keir@xxxxxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| References: | <20070302160652.GB21544@xxxxxxxxxxxxxxxxxxxxxxx> <C20E00AE.A839%keir@xxxxxxxxxxxxx> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| User-agent: | Mutt/1.5.9i |
On Fri, Mar 02, 2007 at 04:26:22PM +0000, Keir Fraser wrote: > On 2/3/07 16:06, "John Levon" <levon@xxxxxxxxxxxxxxxxx> wrote: > > > In several places after setting u->len we return directly on error. > > Apart from the partial write case, it seems all of these should be > > resetting u->len to 0 as happens in the success case? > > Indeed. Now fixed (along with a couple of other bugs in that function). Also, the BUG_ON in xenbusdrv_queue_reply() looks odd to me (in fact the whole function does). Are we really guaranteed that a reply message will be less than a page size? And it doesn't seem right to just stomp on the buffer contents if we wrap right past the consumer value. We've seen both the BUG_ON (well, the ASSERT) and "xenstore-ls /" hang. Looking into exactly why now... regards john _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [Xen-devel] xenbus_dev_write and failed writes, Keir Fraser |
|---|---|
| Next by Date: | Re: [Xen-devel] xenbus_dev_write and failed writes, Keir Fraser |
| Previous by Thread: | Re: [Xen-devel] xenbus_dev_write and failed writes, Keir Fraser |
| Next by Thread: | Re: [Xen-devel] xenbus_dev_write and failed writes, Keir Fraser |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
