|
xen-devel
[Xen-devel] Re: [patch 04/26] Xen-paravirt_ops: Add pagetable accessors
|
To: |
Ingo Molnar <mingo@xxxxxxx> |
|
Subject: |
[Xen-devel] Re: [patch 04/26] Xen-paravirt_ops: Add pagetable accessors to pack and unpack pagetable entries |
|
From: |
Jeremy Fitzhardinge <jeremy@xxxxxxxx> |
|
Date: |
Wed, 28 Feb 2007 12:12:37 -0800 |
|
Cc: |
Zachary Amsden <zach@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx, virtualization@xxxxxxxxxxxxxx, Rusty Russell <rusty@xxxxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, Chris Wright <chrisw@xxxxxxxxxxxx>, Andi Kleen <ak@xxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> |
|
Delivery-date: |
Wed, 28 Feb 2007 12:12:03 -0800 |
|
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxx |
|
In-reply-to: |
<20070228083203.GB8866@xxxxxxx> |
|
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
|
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
|
List-post: |
<mailto:xen-devel@lists.xensource.com> |
|
List-subscribe: |
<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
|
List-unsubscribe: |
<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
|
References: |
<20070227081337.434798469@xxxxxxxx> <20070227081630.311681690@xxxxxxxx> <20070227100850.GA10827@xxxxxxx> <45E47DEF.70405@xxxxxxxx> <20070228083203.GB8866@xxxxxxx> |
|
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
|
User-agent: |
Thunderbird 1.5.0.9 (X11/20070212) |
Ingo Molnar wrote:
>> Yes, but it happens after asm/paravirt.h has already included some
>> things, and it ends up causing problems. paravirt.h still defines
>> various stub functions in the !CONFIG_PARAVIRT case, so it needs to do
>> the includes either way.
>>
>
> hm, it then needs to be fixed first, instead of adding to the mess.
>
OK, I've fixed this by hoisting all the native_* implementations into
pgtable.h. In the !PARAVIRT case the normal macros directly use the
native_* functions, and in the PARAVIRT case they're used by the native
paravirt_ops. This has the nice property of avoiding this specific
problem, and also generally removes code duplication.
J
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
| <Prev in Thread] |
Current Thread |
[Next in Thread>
|
- [Xen-devel] Re: [patch 06/26] Xen-paravirt_ops: paravirt_ops: allocate a fixmap slot, (continued)
[Xen-devel] [patch 17/26] Xen-paravirt_ops: Add nosegneg capability to the vsyscall page notes, Jeremy Fitzhardinge
[Xen-devel] [patch 07/26] Xen-paravirt_ops: Allow paravirt backend to choose kernel PMD sharing, Jeremy Fitzhardinge
[Xen-devel] [patch 09/26] Xen-paravirt_ops: remove HAVE_ARCH_MM_LIFETIME, define no-op architecture implementations, Jeremy Fitzhardinge
- [Xen-devel] Re: [patch 09/26] Xen-paravirt_ops: remove HAVE_ARCH_MM_LIFETIME, define no-op architecture implementations, James Bottomley
- [Xen-devel] Re: [patch 09/26] Xen-paravirt_ops: remove HAVE_ARCH_MM_LIFETIME, define no-op architecture implementations, Jeremy Fitzhardinge
- [Xen-devel] Re: [patch 09/26] Xen-paravirt_ops: remove HAVE_ARCH_MM_LIFETIME, define no-op architecture implementations, James Bottomley
- [Xen-devel] Re: [patch 09/26] Xen-paravirt_ops: remove HAVE_ARCH_MM_LIFETIME, define no-op architecture implementations, Jeremy Fitzhardinge
- [Xen-devel] Re: [patch 09/26] Xen-paravirt_ops: remove HAVE_ARCH_MM_LIFETIME, define no-op architecture implementations, James Bottomley
- [Xen-devel] Re: [patch 09/26] Xen-paravirt_ops: remove HAVE_ARCH_MM_LIFETIME, define no-op architecture implementations, Jeremy Fitzhardinge
|
|
|
Home