WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Error in XendCheckpoint: failed to flush file

To: "Graham, Simon" <Simon.Graham@xxxxxxxxxxx>, Stefan Berger <stefanb@xxxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] Error in XendCheckpoint: failed to flush file
From: Keir Fraser <keir@xxxxxxxxxxxxx>
Date: Wed, 28 Feb 2007 17:17:20 +0000
Delivery-date: Wed, 28 Feb 2007 09:16:42 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <342BAC0A5467384983B586A6B0B3767104BE106A@xxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcdbBqwu6tNHM8b5Edu40AAWy6hiGQAL/KvwAAlrrsg=
Thread-topic: [Xen-devel] Error in XendCheckpoint: failed to flush file
User-agent: Microsoft-Entourage/11.2.5.060620


On 28/2/07 16:15, "Graham, Simon" <Simon.Graham@xxxxxxxxxxx> wrote:

> Note that I thought about plumbing the live flag through to
> xc_linux_restore as is done with xc_linux_save but decided I didn't want
> to change the API... therefore I changed xc_linux_restore to figure out
> if the fd is a socket or not... hopefully this works on Solaris??? (just
> testing now).

Use of the live flag to gate the flush/sync calls is not a good idea. We can
'live save' to disc (checkpointing) and we can 'non-live migrate' via a
socket. So the live flag is not really an indicator of what the file
descriptor maps to (file vs. socket). Best to unconditionally try the
flush/sync and ignore errors.

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel