Re: [Xen-devel] new domain builder breaks compatibility

[John Levon <levon@xxxxxxxxxxxxxxxxx>]

On Thu, Feb 01, 2007 at 05:33:20PM +0100, Gerd Hoffmann wrote:

> >  822         if ( (v_end - vstack_end) < (512UL << 10) )
> >  823         {
> >  824             /* Add extra 4MB to get >= 512kB padding. */
> >  825             if ( !increment_ulong(&v_end, 1UL << 22) )
> >  826                 goto error_out;
> >  827         }
> 
> No, you are right, it's 4MB unconditionally.  Seems to have changed
> though since I checked last time.
> 
> > Surely that guarantees we get at least 512Kb and it ends on a 4Mb
> > boundary?
> 
> Yep.  Is the 2MB alignment ok for Solaris?  You can depend on the 512kb
> only anyway, so the alignment shouldn't matter much ...

I think we could probably make it 2Mb. I'll test it out with your patch.
I don't see a reason why it would fail on 3.0.3 or 3.0.4 anyway.

regards
john

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel