WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] new domain builder breaks compatibility

John Levon wrote:
> On Thu, Feb 01, 2007 at 04:15:16PM +0100, Gerd Hoffmann wrote:
> Hmm... am I misunderstanding this code:

>  822         if ( (v_end - vstack_end) < (512UL << 10) )
>  823         {
>  824             /* Add extra 4MB to get >= 512kB padding. */
>  825             if ( !increment_ulong(&v_end, 1UL << 22) )
>  826                 goto error_out;
>  827         }

No, you are right, it's 4MB unconditionally.  Seems to have changed
though since I checked last time.

> Surely that guarantees we get at least 512Kb and it ends on a 4Mb
> boundary?

Yep.  Is the 2MB alignment ok for Solaris?  You can depend on the 512kb
only anyway, so the alignment shouldn't matter much ...

cheers,
  Gerd

-- 
Gerd Hoffmann <kraxel@xxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel