WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] new domain builder fix to boot domU on IA64.

To: Isaku Yamahata <yamahata@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] new domain builder fix to boot domU on IA64.
From: Gerd Hoffmann <kraxel@xxxxxxx>
Date: Wed, 31 Jan 2007 12:58:14 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 31 Jan 2007 03:57:43 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20070131025608.GE23281%yamahata@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20070130122631.GI25482%yamahata@xxxxxxxxxxxxx> <45BF50EC.4020300@xxxxxxx> <20070131025608.GE23281%yamahata@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird 1.5.0.9 (X11/20060911)
Isaku Yamahata wrote:
> XEN_DOMCTL_arch_setup hypercall sets up EFI memory map,
> xen-faked EFI firmware and etc. So it should be called before
> loading kernel/initrd images.

Why is this order important?

> How about adding new methods like setup_meminit, setup_firmware, setup_boot
> (Or please suggest better names.) to struct xc_dom_loader?

Certainly not to "struct xc_dom_loader", that one is for binary formats
such as ELF and thus architecture-independant.

Maybe we could put that into "struct xc_dom_arch".  I've intentionally
tried to keep the code which does hypercalls separately though.

> And call setup_meminit at xc_dom_boot_mem_init(),
>          setup_firmware at the beginning of xc_dom_build_image(),
>          setup_boot at xc_dom_boot_image().

Only the xc_dom_boot_*() functions are supposed to invoke hypercalls.
Thus the firmware setup can happen either at the end of
xc_dom_boot_mem_init or at the start of xc_dom_boot_image.

cheers,

  Gerd

-- 
Gerd Hoffmann <kraxel@xxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel