Re: [Xen-devel] [PATCH] new domain builder fix to boot domU on IA64.

[Gerd Hoffmann <kraxel@xxxxxxx>]

> +static int arch_setup_middle(struct xc_dom_image *dom)
> +{
>      DECLARE_DOMCTL;
>      int rc;
>  
> @@ -268,16 +280,35 @@ static int arch_setup_early(struct xc_do
>      domctl.cmd = XEN_DOMCTL_arch_setup;
>      domctl.domain = dom->guest_domid;
>      domctl.u.arch_setup.flags = 0;
> +
> +    /* dom->start_info_pfn should be initialized by alloc_magic_pages().
> +     * However it is called later. So we initialize here.
> +     */
> +    dom->start_info_pfn = dom->total_pages - 3;

Is it an option to call arch_setup_middle as one of the first things in
xc_dom_boot_image()?  That would avoid the start_info_pfn trickery ...

The only thing which happens between the current and the suggested place
is that domU pages are mapped and data is copyed to them.  No other
hypercalls.

If that works out we might consider giving some more desciptive names to
the arch hooks, such as "arch_setup_{meminit,bootearly,bootlate}" or so.

cheers,
  Gerd

-- 
Gerd Hoffmann <kraxel@xxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel