Re: [Xen-devel] [PATCH] Cleanup asm-x86/guest_access.h

["Christoph Egger" <Christoph.Egger@xxxxxxx>]

On Friday 12 January 2007 14:37, Keir Fraser wrote:
> On 12/1/07 12:01, "Petersson, Mats" <Mats.Petersson@xxxxxxx> wrote:
> >> copy_{to,from}_user() and copy_{to,from}_user_hvm() expect a non-const
> >> argument as the first argument. So I remove the consts from
> >> the initializer.
> >> I replace typeof with __typeof__, which is always available
> >> in gcc - it is
> >> not, when the -ansi option is used.
> >
> > And is it expected that Xen will EVER be compiled with -ansi? I think
> > there's enough gcc-isms in other places that this will never happen -
> > not that it really makes any difference, I'm just curious if anyone
> > "cares"...
>
> Yes, I'm going to take the const cleanups but bin the __typeof__ changes.

Do you also take the small bugfix in the __copy_field_from_guest() function
at the very bottom in my patch ?




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel